Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch unified_mode to resource not provider #240

Closed
wants to merge 1 commit into from
Closed

Switch unified_mode to resource not provider #240

wants to merge 1 commit into from

Conversation

EMH333
Copy link

@EMH333 EMH333 commented Nov 22, 2021 •
edited
Loading

unified_mode needs to be enabled for the resource, not provider. This correctly fixes the deprecation error in Chef 17.

Works as expected with OSL's base cookbook

Check List

@lamont-granquist
Copy link
Contributor

No, it isn't appropriate to do that with a true since now the behavior of the cookbook will be different on old chef-client 12.x which this cookbook still needs to support.

This needs a flag engineered specifically for this cookbook and pretty much only this cookbook which doesn't exist yet.

@lamont-granquist
Copy link
Contributor

See:

chef/chef#12502

and

chef/cookstyle#936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EMH333 @lamont-granquist